fix: spark connect extra class path - #755
Open
Maleware wants to merge 5 commits into
Open
Conversation
Member
Author
|
lfrancke
requested changes
Aug 25, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
a "drive by" review. I didn't actually test the change but it looks sane to me in general. Thanks for catching.
| // java.lang.invoke.SerializedLambda to field | ||
| // org.apache.spark.rdd.MapPartitionsRDD.f of type scala.Function3 | ||
| ( | ||
| "spark.executor.extraClassPath".to_string(), |
Member
There was a problem hiding this comment.
I don't know enough about how our operators work: Can this still be overridden/appended to by users? That is a relatively "common" property.
Member
Author
There was a problem hiding this comment.
We can still override but not extend extraClassPath in all roles independently.
| "spark.kubernetes.executor.container.image".to_string(), | ||
| Some(spark_image), | ||
| ), | ||
| // Must mirror `spark.driver.extraClassPath` on the server. |
Member
There was a problem hiding this comment.
If that is the case...can/should we extract this into a constant or function?
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spark-connect: adds missing class patch of spark-connect in exectuer
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker